Skip to content

Conversation

@valassi
Copy link
Member

@valassi valassi commented Aug 6, 2024

Fix clang-format version to v15 see #952

…-format v15 from cvmfs if a more recent version is installed madgraph5#952
@valassi valassi changed the title WIP Fix clang-format version to v15 Fix clang-format version to between v13 and v15 Aug 8, 2024
@valassi
Copy link
Member Author

valassi commented Aug 8, 2024

Hi @oliviermattelaer I'd like to merge this, just to have fewer PRs up in the air.

This should be totslly non controversial, only changes a script that I use in generateAndCompare. It needs to use clang format not higher than v15, else all formatting will change.

Let me know if you have comments please, but I might merge anyway.

git checkout upstream/master $(git ls-tree --name-only HEAD */CODEGEN*txt)

Note: I could not test this fully on itgold91 because of mg5amcnlo/mg5amcnlo#127
@valassi
Copy link
Member Author

valassi commented Aug 8, 2024

Note: I could not test this fully on itgold91 because of mg5amcnlo/mg5amcnlo#127

@oliviermattelaer
Copy link
Member

no objection.

@valassi
Copy link
Member Author

valassi commented Aug 8, 2024

no objection.

Thanks :-)

Merging

@valassi valassi merged commit f82c1ac into madgraph5:master Aug 8, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Aug 8, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Aug 10, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix clang-format version and eventually upgrade from v15 to v17

2 participants