Check if the second helicity filtering in fortran for mirror processes can be removed #941
Description
Hi @oliviermattelaer ,
as discussed in #935 (comment)
This is a reminder to check if the second helicity filtering in fortran for mirror processes can be removed.
For the moment, my proposal to solve #872 via PR #935 is to
- keep computing twice helicities in fortran
- keep computing only once helicities in cudacpp
- add a second reset_cumulative_variable call in cudacpp for mirri processes (to fix 872 and ensure that frtran and cudacpp give the same results)
- add a sanity check in fortran that the two lists of good helicities are the same
If, as you suggest, we eventually find that helicities can be computed only once in fortran, then
- the second reset_cumative_variable call can be removed in cudacpp
- there is no need for a sanity chec in fortran any more, as helicities are computed only once
I assign this to you... Low priority, in my opinion
Thanks
Andrea
Metadata
Metadata
Assignees
Labels
No labels