Skip to content

Conversation

@mglotov
Copy link
Contributor

@mglotov mglotov commented Oct 27, 2023

PR Description

Set resources for Loki, otherwise it uses values from LimitRange configuration and it isn't enough.

Fixes #318

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov requested a review from a team October 27, 2023 10:43
@mglotov mglotov merged commit 49c3894 into main Oct 31, 2023
@mglotov mglotov deleted the fix/loki-resources branch October 31, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: loki stack resources defaults are not enough to work

4 participants