feat(wait-for/event): support native DOM EventTargets #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes machty#180. Also removes `.on()` from the assertion message, as it was not supported.
Owner
|
I'm sorry it's taken me so long to look at this; I think this looks pretty good :). Do you still feel that this is a valuable addition to e-c? Could I convince you to add one more commit that adds docs to this page? |
Contributor
Author
|
No problem and thank you. Yes, I do believe this is still a valuable addition, especially since Ember Core is going to I'll add another commit that documents this feature. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180.
Also removes
.on()from the assertion message, as it was not supported.