[k8sops] Remove liveness probes from DB #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already use readiness probes to make sure dbnodes are bootstrapped before taking various actions. Liveness probes are usually a good idea, but in the case of the DB we'd rather a deadlocked node remain up so we can debug vs. automatically killing it.
ryanhall07
approved these changes
Apr 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
+ Coverage 75.33% 76.00% +0.66%
==========================================
Files 32 32
Lines 4103 2538 -1565
==========================================
- Hits 3091 1929 -1162
+ Misses 724 430 -294
+ Partials 288 179 -109 Continue to review full report at Codecov.
|
linasm
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use readiness probes to make sure dbnodes are bootstrapped
before taking various actions. Liveness probes are usually a good idea,
but in the case of the DB we'd rather a deadlocked node remain up so we
can debug vs. automatically killing it.