Skip to content

Conversation

@nbroyles
Copy link
Collaborator

Thanks for contributing to the M3DB Operator! We'd love to accept your contribution, but we require that most issues
outside of trivial changes such as typo corrections have an issue associated with the pull request. So please open an
issue
first!

Marking namespaces as ready requires the coordinator to check
each dbnode to see if the namespace is available (via a read).
This cannot proceed successfully without a placement as the
dbnode blocks until it has one. Therefore, ensure placement
gets created before namespaces so dbnode can respond to
the coordinator.
Copy link
Collaborator

@schallert schallert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #261 (0b1bbea) into master (2c89672) will increase coverage by 0.03%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   75.45%   75.48%   +0.03%     
==========================================
  Files          31       32       +1     
  Lines        2310     2313       +3     
==========================================
+ Hits         1743     1746       +3     
  Misses        425      425              
  Partials      142      142              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c89672...0b1bbea. Read the comment docs.

@nbroyles nbroyles merged commit a2c1ab8 into master Jan 11, 2021
@nbroyles nbroyles deleted the nb/fix-startup branch January 11, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants