Skip to content

Conversation

@jeromefroe
Copy link
Collaborator

This commit adds a new docs file covering how to use the new operator.m3db.io/update annotation to enable the operator to perform updates.

@jeromefroe jeromefroe requested a review from schallert October 2, 2020 18:45
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #240 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   76.35%   76.25%   -0.10%     
==========================================
  Files          30       30              
  Lines        2165     2165              
==========================================
- Hits         1653     1651       -2     
- Misses        379      380       +1     
- Partials      133      134       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9769235...f3ceecf. Read the comment docs.

@@ -0,0 +1,45 @@
# Updating a Cluster
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@schallert schallert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 2 minor things


```bash
for i in {1..3}; do
kubectl annotate statefulset my-cluster-rep$i operator.m3db.io/update=enabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think you could simplify this to one more "Kube-like" command:

kubectl annotate statefulset -l operator.m3db.io/cluster=my-cluster operator.m3db.io/update=enabled

@jeromefroe jeromefroe merged commit 12ebef6 into master Oct 2, 2020
@jeromefroe jeromefroe deleted the jerome/docs/updating-a-cluster branch October 2, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants