Added initial support for PodMetaData, handling Annotations only #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schallert
approved these changes
Apr 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 75.23% 75.30% +0.07%
==========================================
Files 30 30
Lines 2104 2110 +6
==========================================
+ Hits 1583 1589 +6
Misses 393 393
Partials 128 128 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general Annotations in the ClusterSpec get applied to both the Services and the Pods. There are cases where the user wants annotation exclusively for the Pod, such as when marking a Pod to be scraped by Prometheus. This PR puts in an ObjectMeta at the PodMetadata metav1.ClusterSpec level to facilitate specifying Pod-only Metadata. I've only implemented Annotations. I've added a test case for the Pod-only annotations.