arm64: pinenote_defconfig: Explicitly enable binfmt options like COREDUMP #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DUMP
Previously ``CONFIG_COREDUMP`` was explicitly disabled, while that
option is ``default y``, so enabled by default.
More over, its help text says the following:
This option enables support for performing core dumps. You almost
certainly want to say Y here. Not necessary on systems that never
need debugging or only ever run flawless code.
I think it's safe to say that the PineNote ('currently') does NOT fall
in that category ;-) so remove the disablement.
While that in itself is enough, due to ``default y``, the Debian kernel
has explicitly enabled various options from ``fs/Kconfig.binfmt`` which
would be enabled by default. So lets follow suit.
Suggested-by: hrdl <[email protected]> # on IRC
Signed-off-by: Diederik de Haas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
CONFIG_COREDUMPwas explicitly disabled, while that option isdefault y, so enabled by default.More over, its help text says the following:
I think it's safe to say that the PineNote ('currently') does NOT fall in that category ;-) so remove the disablement.
While that in itself is enough, due to
default y, the Debian kernel has explicitly enabled various options fromfs/Kconfig.binfmtwhich would be enabled by default. So lets follow suit.