fix: double encoding of array parameters in signature base #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add tests for this? |
|
Please rebase, |
…racters - Adjust assertions for array parameters to match actual output format. - Update tests for special character handling to expect double-encoded characters. - Modify bracket notation tests to verify consistent encoding pattern. - Ensure test expectations match the actual output of the implemented method.
Bikash-bluebash
force-pushed
the
fix-array-param-encoding
branch
from
5b727ed to
6bad83a
Compare
|
Hello @lunks , please have a review now. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using array parameters like
'includes[]': %w[value1 value2]in requests, the OAuth1 signature calculation fails with a 401 unauthorized error because the square brackets ([]) are being double-encoded in the signature base string.The signature base string was incorrectly encoding
includes[]asincludes%255B%255Dinstead of the correctincludes%5B%5D.Solution
This PR implements proper handling of array parameters in the signature base generation:
Testing
Tested with an API that was previously failing with array parameters, which now works correctly.
Fix: #12