fix: fix crash in Blueprints.js SearchInput renderer #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasbach@13118cd introduced a `ref` property to the `inputProps` of `SearchInput`. This is not compatible with the `ref` property of the Blueprints.js `InputGroup` component and needs to be passed to the `inputRef` property instead. Fixes: lukasbach#197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
13118cd introduced a
refproperty to theinputPropsofSearchInput. This is not compatible with therefproperty of the Blueprints.jsInputGroupcomponent and needs to be passed to theinputRefproperty instead.Fixes: #197