Skip to content

Conversation

@mpatnode
Copy link
Contributor

So it seems that ifupdown isn't compatible with udev which I was reluctant to remove on my ReadyNAS OS. Not sure what huge value you get vs ifconfig (maybe the --force? option) but it was easy enough to make it optional.

Copy link
Owner

@ltpitt ltpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @mpatnode!

All very good points and, to be honest...

I think this is a very good direction and that we should get rid of all the requirements possible and make the code as universally working as possible.
Therefore I'd suggest completely removing ifupdown in order to simplify code and its future maintenance and increase its compatibility.

What do you think?

@mpatnode
Copy link
Contributor Author

Fine by me. I don't have a Raspberry Pi to test with, but I assume the OS came with standard ifconfig? Change coming.

@ltpitt
Copy link
Owner

ltpitt commented Aug 24, 2020

Fine by me. I don't have a Raspberry Pi to test with, but I assume the OS came with standard ifconfig? Change coming.

Mmmmh seems like this could be a problem...
https://raspberrypi.stackexchange.com/questions/1409/easiest-way-to-show-my-ip-address

@mpatnode
Copy link
Contributor Author

So it looks like this is a can of worms. ifconfig has been deprecated for "ip", so maybe the way it is now is for the best.

@mpatnode mpatnode closed this Aug 24, 2020
@mpatnode mpatnode reopened this Aug 24, 2020
@mpatnode
Copy link
Contributor Author

This might do the trick:
ip link set wlan0 down
ip link set wlan0 up

@ltpitt
Copy link
Owner

ltpitt commented Aug 24, 2020

So it looks like this is a can of worms. ifconfig has been deprecated for "ip", so maybe the way it is now is for the best.
Agreed but we should also not leave other users in the cold.

I think that the pre-requisite check section of the script should find out which tools are available on the pc running it and use that information to let the automation work correctly without forcing the user to configure / change anything.
I will install the newest raspbian on a raspberry pi and try all the old and new commands.

In the meantime we can complete this merge since it contains many other nice features.
For the moment being your idea about using a flag to switch between UDEV / ifupdown seems to be the cleanest solution that keeps other users functionality intact.

@ltpitt ltpitt merged commit e958acb into ltpitt:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants