Skip to content

[DO NOT MERGE] Fix TransferGateway.withdrawalReceiptAsync() to handle missing token contract address #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] Fix TransferGateway.withdrawalReceiptAsync() to handle missing token contract address #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"name": "Loom Network",
"url": "https://loomx.io"
},
"version": "1.60.1",
"version": "1.60.2",
"keywords": [
"blockchain",
"dappchain"
Expand Down
9 changes: 6 additions & 3 deletions src/contracts/transfer-gateway.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ export interface IUnclaimedToken {

export interface IWithdrawalReceipt {
tokenOwner: Address
// Mainnet address of token contract
tokenContract: Address
// Mainnet address of token contract (NOTE: not set when withdrawing LOOM via Binance Gateway)
tokenContract?: Address
tokenKind: TransferGatewayTokenKind
// ERC721/X token ID
tokenId?: BN
Expand Down Expand Up @@ -402,9 +402,12 @@ export class TransferGateway extends Contract {
value = tokenAmount
break
}

return {
tokenOwner: Address.UnmarshalPB(receipt.getTokenOwner()!),
tokenContract: Address.UnmarshalPB(receipt.getTokenContract()!),
tokenContract: receipt.getTokenContract()
? Address.UnmarshalPB(receipt.getTokenContract()!)
: undefined,
tokenKind,
tokenId,
tokenAmount,
Expand Down