Fix no-setup-in-describe to correctly detect describe calls #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was one call of `astUtils.isDescribe` which has been called without the second parameter which caused the function to accept `undefined` as a valid alias for suite function names. Additionally there are cases where we don’t get a node name for `CallExpressions` (e.g. `foo()()`). So in such cases the extracted node name is `undefined` and `isDescribe` will return true due to the above mentioned bug. Fixes: #172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was one call of
astUtils.isDescribewhich has been called without the second parameter which caused the function to acceptundefinedas a valid alias for suite function names. Additionally there are cases where we don’t get a node name forCallExpressions(e.g.foo()()). So in such cases the extracted node name isundefinedandisDescribewill return true due to the above mentionedbug.
Fixes: #172