Skip to content

[WebAssembly] Enable multivalue and reference-types in generic CPU config #80923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 29, 2024
Merged

[WebAssembly] Enable multivalue and reference-types in generic CPU config #80923

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d6fd487
[WebAssembly] Add more features to generic CPU config
aheejin Feb 6, 2024
e501363
Merge branch 'main' into enable_features
aheejin Feb 7, 2024
01ac8bd
Mention that ABI is not turned on
aheejin Feb 23, 2024
7119137
Merge branch 'main' into enable_features
aheejin Feb 23, 2024
17e81e3
Merge branch 'main' into enable_features
aheejin Feb 23, 2024
26caed5
Merge branch 'main' into enable_features
aheejin Apr 23, 2024
de6aa6a
Enable only multivalue and reference types
aheejin Apr 23, 2024
91df749
Enable multivalue and reference-types in bleeding-edge
aheejin Apr 23, 2024
f4aee60
Update clang/docs/ReleaseNotes.rst
aheejin Apr 24, 2024
af79d4e
Merge branch 'main' into enable_features
aheejin Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clang/docs/ReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,10 @@ AIX Support
WebAssembly Support
^^^^^^^^^^^^^^^^^^^

The -mcpu=generic configuration now enables nontrapping-fptoint, multivalue,
reference-types, and bulk-memory.These proposals are standardized and available
in all major engines.
Copy link
Member

@sunfishcode sunfishcode Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also mention that enabling multivalue here just means enabling the language feauture, and not changing the ABI?

Copy link
Member Author

@aheejin aheejin Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


AVR Support
^^^^^^^^^^^

Expand Down
18 changes: 12 additions & 6 deletions clang/lib/Basic/Targets/WebAssembly.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,19 +147,25 @@ void WebAssemblyTargetInfo::setFeatureEnabled(llvm::StringMap<bool> &Features,
bool WebAssemblyTargetInfo::initFeatureMap(
llvm::StringMap<bool> &Features, DiagnosticsEngine &Diags, StringRef CPU,
const std::vector<std::string> &FeaturesVec) const {
if (CPU == "bleeding-edge") {
Features["nontrapping-fptoint"] = true;
auto addGenericFeatures = [&]() {
Features["sign-ext"] = true;
Features["mutable-globals"] = true;
Features["nontrapping-fptoint"] = true;
Features["bulk-memory"] = true;
Features["reference-types"] = true;
Features["multivalue"] = true;
};
auto addBleedingEdgeFeatures = [&]() {
Features["atomics"] = true;
Features["mutable-globals"] = true;
Features["tail-call"] = true;
Features["reference-types"] = true;
Features["multimemory"] = true;
setSIMDLevel(Features, SIMD128, true);
};
if (CPU == "bleeding-edge") {
addGenericFeatures();
addBleedingEdgeFeatures();
} else if (CPU == "generic") {
Features["sign-ext"] = true;
Features["mutable-globals"] = true;
addGenericFeatures();
}

return TargetInfo::initFeatureMap(Features, Diags, CPU, FeaturesVec);
Expand Down
8 changes: 4 additions & 4 deletions clang/test/Preprocessor/wasm-target-features.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,15 @@
//
// GENERIC-DAG:#define __wasm_sign_ext__ 1{{$}}
// GENERIC-DAG:#define __wasm_mutable_globals__ 1{{$}}
// GENERIC-NOT:#define __wasm_nontrapping_fptoint__ 1{{$}}
// GENERIC-NOT:#define __wasm_bulk_memory__ 1{{$}}
// GENERIC-DAG:#define __wasm_nontrapping_fptoint__ 1{{$}}
// GENERIC-DAG:#define __wasm_bulk_memory__ 1{{$}}
// GENERIC-DAG:#define __wasm_multivalue__ 1{{$}}
// GENERIC-DAG:#define __wasm_reference_types__ 1{{$}}
// GENERIC-NOT:#define __wasm_simd128__ 1{{$}}
// GENERIC-NOT:#define __wasm_atomics__ 1{{$}}
// GENERIC-NOT:#define __wasm_tail_call__ 1{{$}}
// GENERIC-NOT:#define __wasm_multimemory__ 1{{$}}
// GENERIC-NOT:#define __wasm_exception_handling__ 1{{$}}
// GENERIC-NOT:#define __wasm_multivalue__ 1{{$}}
// GENERIC-NOT:#define __wasm_reference_types__ 1{{$}}
// GENERIC-NOT:#define __wasm_extended_const__ 1{{$}}

// RUN: %clang -E -dM %s -o - 2>&1 \
Expand Down