-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[flang] Implemented a warning about contiguity of compile time constant values #161084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b380c14
[flang] Implemented a warning about contiguity of compile time consta…
eugeneepshteyn fb8269d
clang-format
eugeneepshteyn a74f608
added test
eugeneepshteyn e5191eb
Merge branch 'llvm:main' into is-contiguous-const
eugeneepshteyn 36273d6
Merge branch 'llvm:main' into is-contiguous-const
eugeneepshteyn e3d6411
Code review feedback
eugeneepshteyn ca108a3
Updated test with the new error message
eugeneepshteyn da21d5a
Merge branch 'main' into is-contiguous-const
eugeneepshteyn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -799,12 +799,20 @@ Expr<Type<TypeCategory::Logical, KIND>> FoldIntrinsicFunction( | |
| } | ||
| } else if (name == "is_contiguous") { | ||
| if (args.at(0)) { | ||
| auto warnContiguous = [&]() { | ||
| if (auto source{args[0]->sourceLocation()}) { | ||
| context.Warn(common::UsageWarning::ConstantIsContiguous, *source, | ||
| "constant values constructed at compile time are likely to be contiguous"_warn_en_US); | ||
|
||
| } | ||
| }; | ||
| if (auto *expr{args[0]->UnwrapExpr()}) { | ||
| if (auto contiguous{IsContiguous(*expr, context)}) { | ||
| warnContiguous(); | ||
| return Expr<T>{*contiguous}; | ||
| } | ||
| } else if (auto *assumedType{args[0]->GetAssumedTypeDummy()}) { | ||
| if (auto contiguous{IsContiguous(*assumedType, context)}) { | ||
| warnContiguous(); | ||
| return Expr<T>{*contiguous}; | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| ! RUN: %python %S/test_errors.py %s %flang_fc1 -pedantic -Werror | ||
| integer, parameter :: num = 3 | ||
| integer, parameter :: arr(num)=[(i, i=1,num)] | ||
| !WARNING: constant values constructed at compile time are likely to be contiguous [-Wconstant-is-contiguous] | ||
| logical, parameter :: result=is_contiguous(arr(num:1:-1)) | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please always use braced initialization in everything before lowering or in the runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done