Skip to content

Conversation

@hjyamauchi
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Sep 16, 2025

@llvm/pr-subscribers-platform-windows

Author: Hiroshi Yamauchi (hjyamauchi)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/159157.diff

1 Files Affected:

  • (modified) llvm/lib/Support/Windows/Program.inc (+1-2)
diff --git a/llvm/lib/Support/Windows/Program.inc b/llvm/lib/Support/Windows/Program.inc
index d8d2e181aa337..ec785e407cc57 100644
--- a/llvm/lib/Support/Windows/Program.inc
+++ b/llvm/lib/Support/Windows/Program.inc
@@ -220,8 +220,7 @@ static bool Execute(ProcessInfo &PI, StringRef Program,
       llvm::append_range(EnvBlock, EnvString);
       EnvBlock.push_back(0);
     }
-    // If an empty environment (*Env is size zero), we need to
-    // terminate with two nulls.
+    // Empty environments need to be terminated with two nulls.
     if (Env->size() == 0)
       EnvBlock.push_back(0);
     EnvBlock.push_back(0);

@llvmbot
Copy link
Member

llvmbot commented Sep 16, 2025

@llvm/pr-subscribers-llvm-support

Author: Hiroshi Yamauchi (hjyamauchi)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/159157.diff

1 Files Affected:

  • (modified) llvm/lib/Support/Windows/Program.inc (+1-2)
diff --git a/llvm/lib/Support/Windows/Program.inc b/llvm/lib/Support/Windows/Program.inc
index d8d2e181aa337..ec785e407cc57 100644
--- a/llvm/lib/Support/Windows/Program.inc
+++ b/llvm/lib/Support/Windows/Program.inc
@@ -220,8 +220,7 @@ static bool Execute(ProcessInfo &PI, StringRef Program,
       llvm::append_range(EnvBlock, EnvString);
       EnvBlock.push_back(0);
     }
-    // If an empty environment (*Env is size zero), we need to
-    // terminate with two nulls.
+    // Empty environments need to be terminated with two nulls.
     if (Env->size() == 0)
       EnvBlock.push_back(0);
     EnvBlock.push_back(0);

Copy link
Member

@aganea aganea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@hjyamauchi hjyamauchi merged commit 7c861bc into llvm:main Sep 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants