Skip to content

[clang] Don't fail ExecuteCompilerInvocation() due to caller errors #158695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

[clang] Don't fail ExecuteCompilerInvocation() due to caller errors #158695

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
827307d
[clang] Don't fail `clang::ExecuteCompilerInvocation()` for unrelated…
jansvoboda11 Sep 15, 2025
5200d1a
Add comment
jansvoboda11 Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ CreateFrontendAction(CompilerInstance &CI) {
}

bool ExecuteCompilerInvocation(CompilerInstance *Clang) {
unsigned NumErrorsBefore = Clang->getDiagnostics().getNumErrors();

// Honor -help.
if (Clang->getFrontendOpts().ShowHelp) {
driver::getDriverOptTable().printHelp(
Expand Down Expand Up @@ -292,9 +294,12 @@ bool ExecuteCompilerInvocation(CompilerInstance *Clang) {
}
#endif

// If there were errors in processing arguments, don't do anything else.
if (Clang->getDiagnostics().hasErrorOccurred())
// If there were errors in the above, don't do anything else.
// This intentionally ignores errors emitted before this function to
// accommodate lenient callers that decided to make progress despite errors.
if (Clang->getDiagnostics().getNumErrors() != NumErrorsBefore)
return false;

// Create and execute the frontend action.
std::unique_ptr<FrontendAction> Act(CreateFrontendAction(*Clang));
if (!Act)
Expand Down