ensure that dap_symbol is always initialized

[lexi-nadia]

No description provided.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: None (lexi-nadia)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/156956.diff

1 Files Affected:

• (modified) lldb/tools/lldb-dap/Handler/ModuleSymbolsRequestHandler.cpp (+1-1)

diff --git a/lldb/tools/lldb-dap/Handler/ModuleSymbolsRequestHandler.cpp b/lldb/tools/lldb-dap/Handler/ModuleSymbolsRequestHandler.cpp
index 4a9d256cfa975..4c61138e5007e 100644
--- a/lldb/tools/lldb-dap/Handler/ModuleSymbolsRequestHandler.cpp
+++ b/lldb/tools/lldb-dap/Handler/ModuleSymbolsRequestHandler.cpp
@@ -60,7 +60,7 @@ ModuleSymbolsRequestHandler::Run(const ModuleSymbolsArguments &args) const {
     if (!symbol.IsValid())
       continue;
 
-    Symbol dap_symbol;
+    Symbol dap_symbol = {};
     dap_symbol.id = symbol.GetID();
     dap_symbol.type = symbol.GetType();
     dap_symbol.isDebug = symbol.IsDebug();

[walter-erquinigo]

This change is not ideal. Instead, just define a default constructor for the struct. Otherwise every time someone creates a new Symbol object, they'll have to initialize it manually.

[ashgti]

I'll send an update to initialize all the variables.

[lexi-nadia]

#157150 is already approved - I'm just waiting for someone to merge it and/or for my own commit access to be granted. :)