Skip to content

[lldb-dap] Fix typescript issue in updated typescript code. #156117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

[lldb-dap] Fix typescript issue in updated typescript code. #156117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lldb/tools/lldb-dap/src-ts/ui/symbols-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,18 @@ export class SymbolsProvider extends DisposableContext {
return;
}

this.showSymbolsForModule(session, selectedModule.module);
await this.showSymbolsForModule(session, selectedModule.module);
}

private async showSymbolsForModule(session: vscode.DebugSession, module: DebugProtocol.Module) {
try {
const symbols = await this.getSymbolsForModule(session, module.id.toString());
this.showSymbolsInNewTab(module.name.toString(), symbols);
await this.showSymbolsInNewTab(module.name.toString(), symbols);
} catch (error) {
if (error instanceof Error) {
vscode.window.showErrorMessage("Failed to retrieve symbols: " + error.message);
await vscode.window.showErrorMessage("Failed to retrieve symbols: " + error.message);
} else {
vscode.window.showErrorMessage("Failed to retrieve symbols due to an unknown error.");
await vscode.window.showErrorMessage("Failed to retrieve symbols due to an unknown error.");
}

return;
Expand Down Expand Up @@ -106,7 +106,7 @@ export class SymbolsProvider extends DisposableContext {
const symbolsTableScriptPath = panel.webview.asWebviewUri(vscode.Uri.joinPath(this.getExtensionResourcePath(), "symbols-table-view.js"));

panel.webview.html = getSymbolsTableHTMLContent(tabulatorJsPath, tabulatorCssPath, symbolsTableScriptPath);
panel.webview.postMessage({ command: "updateSymbols", symbols: symbols });
await panel.webview.postMessage({ command: "updateSymbols", symbols: symbols });
}

private getExtensionResourcePath(): vscode.Uri {
Expand Down
Loading