Skip to content

Conversation

eronnen
Copy link
Contributor

@eronnen eronnen commented Aug 23, 2025

  • apply odd table rows color from vscode theme
  • apply hover color from vscode theme
Screencast.From.2025-08-23.14-48-44.webm

@llvmbot
Copy link
Member

llvmbot commented Aug 23, 2025

@llvm/pr-subscribers-lldb

Author: Ely Ronnen (eronnen)

Changes
  • apply odd table rows color from vscode theme
  • apply hover color from vscode theme
Screencast.From.2025-08-23.14-48-44.webm

Full diff: https://github.com/llvm/llvm-project/pull/155097.diff

2 Files Affected:

  • (modified) lldb/tools/lldb-dap/src-ts/ui/symbols-webview-html.ts (+18-2)
  • (modified) lldb/tools/lldb-dap/src-ts/webview/symbols-table-view.ts (+1)
diff --git a/lldb/tools/lldb-dap/src-ts/ui/symbols-webview-html.ts b/lldb/tools/lldb-dap/src-ts/ui/symbols-webview-html.ts
index 88e24f3108787..c00e0d462569a 100644
--- a/lldb/tools/lldb-dap/src-ts/ui/symbols-webview-html.ts
+++ b/lldb/tools/lldb-dap/src-ts/ui/symbols-webview-html.ts
@@ -12,8 +12,13 @@ export function getSymbolsTableHTMLContent(tabulatorJsPath: vscode.Uri, tabulato
         color: var(--vscode-editor-foreground);
       }
 
+      .tabulator .tabulator-header {
+        background-color: var(--vscode-tree-tableOddRowsBackground);
+        color: var(--vscode-editor-foreground);
+      }
+
       .tabulator .tabulator-header .tabulator-col {
-        background-color: var(--vscode-editor-background);
+        background-color: var(--vscode-tree-tableOddRowsBackground);
         color: var(--vscode-editor-foreground);
       }
 
@@ -23,11 +28,22 @@ export function getSymbolsTableHTMLContent(tabulatorJsPath: vscode.Uri, tabulato
       }
 
       .tabulator-row.tabulator-row-even {
+        background-color: var(--vscode-tree-tableOddRowsBackground);
+      }
+
+      @media (hover:hover) and (pointer:fine){
+        .tabulator-row:hover {
+          background-color: var(--vscode-list-hoverBackground);
+          color: var(--vscode-list-hoverForeground);
+        }
+      }
+
+      .tabulator-row.tabulator-selected {
         background-color: var(--vscode-editor-background);
         color: var(--vscode-editor-foreground);
       }
 
-      .tabulator-row.tabulator-selected {
+      .tabulator .tabulator-tableholder .tabulator-table {
         background-color: var(--vscode-editor-background);
         color: var(--vscode-editor-foreground);
       }
diff --git a/lldb/tools/lldb-dap/src-ts/webview/symbols-table-view.ts b/lldb/tools/lldb-dap/src-ts/webview/symbols-table-view.ts
index 8454378abef16..9d346818e384a 100644
--- a/lldb/tools/lldb-dap/src-ts/webview/symbols-table-view.ts
+++ b/lldb/tools/lldb-dap/src-ts/webview/symbols-table-view.ts
@@ -95,6 +95,7 @@ const SYMBOLS_TABLE = new Tabulator("#symbols-table", {
   height: "100vh",
   columns: SYMBOL_TABLE_COLUMNS,
   layout: "fitColumns",
+  selectableRows: false,
   data: previousState?.symbols || [],
 });
 

Copy link
Member

@walter-erquinigo walter-erquinigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the attention to details :) This is what makes this DA great!

@eronnen eronnen merged commit 3cbbc07 into llvm:main Aug 25, 2025
9 checks passed
JDevlieghere pushed a commit to swiftlang/llvm-project that referenced this pull request Oct 10, 2025
* apply odd table rows color from vscode theme
* apply hover color from vscode theme

[Screencast From 2025-08-23
14-48-44.webm](https://github.com/user-attachments/assets/a738ac3c-3e56-4a57-b713-7430c614c415)

(cherry picked from commit 3cbbc07)
JDevlieghere pushed a commit to swiftlang/llvm-project that referenced this pull request Oct 13, 2025
* apply odd table rows color from vscode theme
* apply hover color from vscode theme

[Screencast From 2025-08-23
14-48-44.webm](https://github.com/user-attachments/assets/a738ac3c-3e56-4a57-b713-7430c614c415)

(cherry picked from commit 3cbbc07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants