[lldb] Disable JSONTransportTests on Windows. #153453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to unblock CI. Disabling the tests while I investigate the timeouts.
|
@llvm/pr-subscribers-lldb Author: John Harrison (ashgti) ChangesThis is to unblock CI. Disabling the tests while I investigate the timeouts. Full diff: https://github.com/llvm/llvm-project/pull/153453.diff 1 Files Affected:
diff --git a/lldb/unittests/Host/JSONTransportTest.cpp b/lldb/unittests/Host/JSONTransportTest.cpp
index cb6da6b1bc677..4e94582d3bc6a 100644
--- a/lldb/unittests/Host/JSONTransportTest.cpp
+++ b/lldb/unittests/Host/JSONTransportTest.cpp
@@ -132,6 +132,9 @@ class JSONRPCTransportTest : public JSONTransportTest<JSONRPCTransport> {
} // namespace
+// Failing on Windows, see https://github.com/llvm/llvm-project/issues/153446.
+#ifndef _WIN32
+
TEST_F(HTTPDelimitedJSONTransportTest, MalformedRequests) {
std::string malformed_header =
"COnTent-LenGth: -1\r\nContent-Type: text/json\r\n\r\nnotjosn";
@@ -336,3 +339,5 @@ TEST_F(JSONRPCTransportTest, NoDataTimeout) {
RunOnce<JSONTestType>(/*timeout=*/std::chrono::milliseconds(10)),
FailedWithMessage("timeout"));
}
+
+#endif
|
JDevlieghere
approved these changes
Aug 13, 2025
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 10, 2025
This is to unblock CI. Disabling the tests while I investigate the timeouts. (cherry picked from commit 3a36070)
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 13, 2025
This is to unblock CI. Disabling the tests while I investigate the timeouts. (cherry picked from commit 3a36070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to unblock CI. Disabling the tests while I investigate the timeouts.