Skip to content

[X86] Correct an assertion message (NFC) #149386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Conversation

tgross35
Copy link
Contributor

I introduced this in a78a0f8 ("[X86] Align f128 and i128 to 16 bytes"). Correct the message here.

I introduced this in a78a0f8 ("[X86] Align f128 and i128 to 16
bytes"). Correct the message here.
@llvmbot
Copy link
Member

llvmbot commented Jul 17, 2025

@llvm/pr-subscribers-backend-x86

Author: Trevor Gross (tgross35)

Changes

I introduced this in a78a0f8 ("[X86] Align f128 and i128 to 16 bytes"). Correct the message here.


Full diff: https://github.com/llvm/llvm-project/pull/149386.diff

1 Files Affected:

  • (modified) llvm/lib/Target/X86/X86CallingConv.cpp (+1-1)
diff --git a/llvm/lib/Target/X86/X86CallingConv.cpp b/llvm/lib/Target/X86/X86CallingConv.cpp
index 82e8ce4e0bd7c..5d5a705893242 100644
--- a/llvm/lib/Target/X86/X86CallingConv.cpp
+++ b/llvm/lib/Target/X86/X86CallingConv.cpp
@@ -389,7 +389,7 @@ static bool CC_X86_32_I128_FP128(unsigned &ValNo, MVT &ValVT, MVT &LocVT,
   if (!ArgFlags.isInConsecutiveRegsLast())
     return true;
 
-  assert(PendingMembers.size() == 4 && "Should have two parts");
+  assert(PendingMembers.size() == 4 && "Should have four parts");
 
   int64_t Offset = State.AllocateStack(16, Align(16));
   PendingMembers[0].convertToMem(Offset);

@tgross35
Copy link
Contributor Author

@nikic could you review this?

@nikic nikic merged commit 1e7446f into llvm:main Jul 18, 2025
11 checks passed
@tgross35 tgross35 deleted the x86-abi-typo-fix branch July 18, 2025 17:57
tgross35 added a commit to tgross35/llvm-project that referenced this pull request Jul 26, 2025
I introduced this in a78a0f8 ("[X86] Align f128 and i128 to 16
bytes"). Correct the message here.

(cherry picked from commit 1e7446f)
tru pushed a commit to tgross35/llvm-project that referenced this pull request Jul 28, 2025
I introduced this in a78a0f8 ("[X86] Align f128 and i128 to 16
bytes"). Correct the message here.

(cherry picked from commit 1e7446f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants