Skip to content

[mlir][affine] Add Check for 'affine.for' Bound Map Results #127105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 22, 2025
Merged

[mlir][affine] Add Check for 'affine.for' Bound Map Results #127105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b59c62e
added check for affine.for bounds
ayokunle321 Feb 13, 2025
7aa091f
added comments
ayokunle321 Feb 13, 2025
b95f0e5
fixed code style
ayokunle321 Feb 13, 2025
302c2ec
fix style
ayokunle321 Feb 13, 2025
20a24fc
format code properly
ayokunle321 Feb 13, 2025
6cead0b
removed unnecessary comments
ayokunle321 Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mlir/lib/Dialect/Affine/IR/AffineOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1902,6 +1902,10 @@ LogicalResult AffineForOp::verifyRegions() {
if (failed(verifyDimAndSymbolIdentifiers(*this, getUpperBoundOperands(),
getUpperBoundMap().getNumDims())))
return failure();
if (getLowerBoundMap().getNumResults() < 1)
return emitOpError("expected lower bound map to have at least one result");
if (getUpperBoundMap().getNumResults() < 1)
return emitOpError("expected upper bound map to have at least one result");

unsigned opNumResults = getNumResults();
if (opNumResults == 0)
Expand Down
22 changes: 22 additions & 0 deletions mlir/test/Dialect/Affine/invalid.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,3 +541,25 @@ func.func @dynamic_dimension_index() {
}) : () -> ()
return
}

// -----

#map = affine_map<() -> ()>
#map1 = affine_map<() -> (1)>
func.func @no_lower_bound() {
// expected-error@+1 {{'affine.for' op expected lower bound map to have at least one result}}
affine.for %i = max #map() to min #map1() {
}
return
}

// -----

#map = affine_map<() -> ()>
#map1 = affine_map<() -> (1)>
func.func @no_upper_bound() {
// expected-error@+1 {{'affine.for' op expected upper bound map to have at least one result}}
affine.for %i = max #map1() to min #map() {
}
return
}