Skip to content

[compiler-rt][RISCV] Avoid using __init_riscv_feature_bits as a direc… #115316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[compiler-rt][RISCV] Avoid using __init_riscv_feature_bits as a direc… #115316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
188868e
[compiler-rt][RISCV] Avoid using __init_riscv_feature_bits as a direc…
kito-cheng Nov 7, 2024
bf6f1a2
!fixup for formating code
kito-cheng Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions compiler-rt/lib/builtins/cpu_model/riscv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,18 +335,23 @@ static void initRISCVFeature(struct riscv_hwprobe Hwprobes[]) {

static int FeaturesBitCached = 0;

void __init_riscv_feature_bits(void *) CONSTRUCTOR_ATTRIBUTE;
void __init_riscv_feature_bits(void *);
static void __init_riscv_feature_bits_ctor(void) CONSTRUCTOR_ATTRIBUTE;

// A constructor function that sets __riscv_feature_bits, and
// __riscv_vendor_feature_bits to the right values. This needs to run
// only once. This constructor is given the highest priority and it should
// run before constructors without the priority set. However, it still runs
// after ifunc initializers and needs to be called explicitly there.

static void CONSTRUCTOR_ATTRIBUTE __init_riscv_feature_bits_ctor(void) {
__init_riscv_feature_bits(0);
}

// PlatformArgs allows the platform to provide pre-computed data and access it
// without extra effort. For example, Linux could pass the vDSO object to avoid
// an extra system call.
void CONSTRUCTOR_ATTRIBUTE __init_riscv_feature_bits(void *PlatformArgs) {
void __init_riscv_feature_bits(void *PlatformArgs) {

if (FeaturesBitCached)
return;
Expand Down
Loading