/llvm/include/llvm/DebugInfo/DWARF/DWARFFormValue.h:64: Pointless copy ?

[dcb314]

Static analyser cppcheck says:

llvm/include/llvm/DebugInfo/DWARF/DWARFFormValue.h:64:43: performance: Function parameter 'V' should be passed by const reference. [passedByValue]

Source code is

DWARFFormValue(dwarf::Form F, ValueType V) : Form(F), Value(V) {}

Suggest new code:

DWARFFormValue(dwarf::Form F, const ValueType & V) : Form(F), Value(V) {}

[llvmbot]

@llvm/issue-subscribers-tools-llvm-dwarfdump

Author: None (dcb314)

Static analyser cppcheck says:

llvm/include/llvm/DebugInfo/DWARF/DWARFFormValue.h:64:43: performance: Function parameter 'V' should be passed by const reference. [passedByValue]

Source code is

DWARFFormValue(dwarf::Form F, ValueType V) : Form(F), Value(V) {}

Suggest new code:

DWARFFormValue(dwarf::Form F, const ValueType & V) : Form(F), Value(V) {}

[llvmbot]

@llvm/issue-subscribers-debuginfo

Author: None (dcb314)

Static analyser cppcheck says:

llvm/include/llvm/DebugInfo/DWARF/DWARFFormValue.h:64:43: performance: Function parameter 'V' should be passed by const reference. [passedByValue]

Source code is

DWARFFormValue(dwarf::Form F, ValueType V) : Form(F), Value(V) {}

Suggest new code:

DWARFFormValue(dwarf::Form F, const ValueType & V) : Form(F), Value(V) {}

[RKSimon]

Fixed by 79ce70b