bumping `cmake_minimum_required` causes compiler-rt test link failures on Windows

[zmodem]

Surprisingly, it seems the cmake_minimum_required bump from 3.13.4 to 3.20.0 in @mordante's ffb807a is causing some behavior change that makes compiler-rt tests fail to link on Windows.

From the top of https://lab.llvm.org/buildbot/#/builders/127/builds/48120/steps/8/logs/stdio

[58/136] Generating Fuzzer-x86_64-Test.exe
FAILED: projects/compiler-rt/lib/fuzzer/tests/Fuzzer-x86_64-Test.exe C:/b/slave/sanitizer-windows/build/stage1/projects/compiler-rt/lib/fuzzer/tests/Fuzzer-x86_64-Test.exe 
cmd.exe /C "cd /D C:\b\slave\sanitizer-windows\build\stage1\projects\compiler-rt\lib\fuzzer\tests && C:\b\slave\sanitizer-windows\build\stage1\.\bin\clang++.exe FuzzerTestObjects.FuzzerUnittest.cpp.x86_64.o FuzzerTestObjects.gtest-all.cc.x86_64.o C:/b/slave/sanitizer-windows/build/stage1/projects/compiler-rt/lib/fuzzer/tests/RTFuzzerTest.x86_64.lib -o C:/b/slave/sanitizer-windows/build/stage1/projects/compiler-rt/lib/fuzzer/tests/./Fuzzer-x86_64-Test.exe --driver-mode=g++ -Wl,-defaultlib:libcmt,-defaultlib:oldnames"
RTFuzzerTest.x86_64.lib(FuzzerIOWindows.cpp.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in FuzzerTestObjects.FuzzerUnittest.cpp.x86_64.o

I can also reproduce this locally. My CMake version is 3.20.21032501-MSVC_2

> cmake -GNinja -DLLVM_ENABLE_PROJECTS="llvm;clang;compiler-rt" -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_TARGETS_TO_BUILD=X86 ..\llvm && ninja check-fuzzer
[...]
[2985/2987] Generating Fuzzer-x86_64-Test.exe
FAILED: projects/compiler-rt/lib/fuzzer/tests/Fuzzer-x86_64-Test.exe
cmd.exe /C "cd /D C:\src\llvm-project\build.nana\projects\compiler-rt\lib\fuzzer\tests && C:\src\llvm-project\build.nana\.\bin\clang++.exe FuzzerTestObjects.FuzzerUnittest.cpp.x86_64.o FuzzerTestObjects.gtest-all.cc.x86_64.o C:/src/llvm-project/build.nana/projects/compiler-rt/lib/fuzzer/tests/RTFuzzerTest.x86_64.lib -o C:/src/llvm-project/build.nana/projects/compiler-rt/lib/fuzzer/tests/./Fuzzer-x86_64-Test.exe --driver-mode=g++ -Wl,-defaultlib:libcmt,-defaultlib:oldnames"
RTFuzzerTest.x86_64.lib(FuzzerIOWindows.cpp.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MT_StaticRelease' in FuzzerTestObjects.FuzzerUnittest.cpp.x86_64.o

I thought LLVM builds defauled to /MT (and compiler-rt's cmake files does some flag massaging for it here: https://github.com/llvm/llvm-project/blob/llvmorg-16.0.3/compiler-rt/CMakeLists.txt#L398), but for some reason ffb807a changes that?

If I add -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded, it builds. Maybe that should be added as a default somewhere?

[mordante]

Starting with CMake 3.15 it offers CMAKE_MSVC_RUNTIME_LIBRARY so probably that should be used instead of the current work-around.

Maybe a quick fix would be to disable the CMP0091 which probably works with the current work-around.

[rnk]

I'm not familiar with this new option, but you can check out ChooseMSVCRT.cmake for some past history of how we've tried to handle CRT selection. However, compiler-rt is compiled very differently, so it may not be relevant anymore.

[zmodem]

Sent out https://reviews.llvm.org/D150688 to set the CMP0091 policy.

We hit another issue in Chromium where building the toolchain with rpmalloc failed (https://bugs.chromium.org/p/chromium/issues/detail?id=1445671). I've verified that this patch fixes that too.

[zmodem]

The compiler-rt label applies since it's compiler-rt's tests that fail to link.

Also, it seems there are still breakages (https://bugs.chromium.org/p/chromium/issues/detail?id=1445671#c7). I'll try to get a repro for that.

[zmodem]

Also, it seems there are still breakages (https://bugs.chromium.org/p/chromium/issues/detail?id=1445671#c7). I'll try to get a repro for that.

cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS="clang;lld" -DLLVM_ENABLE_RUNTIMES=compiler-rt -DLLVM_TARGETS_TO_BUILD=X86 -DCLANG_ENABLE_STATIC_ANALYZER=OFF -DCLANG_ENABLE_ARCMT=OFF -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF -DLLVM_USE_CRT_RELEASE=MT -DCOMPILER_RT_BUILD_CRT=ON -DCOMPILER_RT_BUILD_LIBFUZZER=OFF -DCOMPILER_RT_BUILD_MEMPROF=OFF -DCOMPILER_RT_BUILD_ORC=OFF -DCOMPILER_RT_BUILD_PROFILE=ON -DCOMPILER_RT_BUILD_SANITIZERS=OFF -DCOMPILER_RT_BUILD_XRAY=OFF -DCOMPILER_RT_DEFAULT_TARGET_ONLY=ON ..\llvm && ninja check-all
[...]
-- Testing: 69999 tests, 60 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90
FAIL: Profile-x86_64 :: gcov-__gcov_flush-terminate.c (67132 of 69999)
******************** TEST 'Profile-x86_64 :: gcov-__gcov_flush-terminate.c' FAILED ********************
Script:
--
: 'RUN: at line 3';   mkdir -p C:\src\llvm-project\build.blabla\runtimes\runtimes-bins\compiler-rt\test\profile\Profile-x86_64\Output\gcov-__gcov_flush-terminate.c.tmp.dir && cd C:\src\llvm-project\build.blabla\runtimes\runtimes-bins\compiler-rt\test\profile\Profile-x86_64\Output\gcov-__gcov_flush-terminate.c.tmp.dir
: 'RUN: at line 4';      C:/src/llvm-project/build.blabla/./bin/clang.exe       -Wl,-incremental:no --coverage C:\src\llvm-project\compiler-rt\test\profile\gcov-__gcov_flush-terminate.c -o C:\src\llvm-project\build.blabla\runtimes\runtimes-bins\compiler-rt\test\profile\Profile-x86_64\Output\gcov-__gcov_flush-terminate.c.tmp
: 'RUN: at line 5';   test -f gcov-__gcov_flush-terminate.gcno
: 'RUN: at line 7';   rm -f gcov-__gcov_flush-terminate.gcda && not KillTheDoctor  C:\src\llvm-project\build.blabla\runtimes\runtimes-bins\compiler-rt\test\profile\Profile-x86_64\Output\gcov-__gcov_flush-terminate.c.tmp
: 'RUN: at line 8';   llvm-cov gcov -t gcov-__gcov_flush-terminate.gcda | FileCheck C:\src\llvm-project\compiler-rt\test\profile\gcov-__gcov_flush-terminate.c
--
Exit Code: 1120

Command Output (stdout):
--
$ ":" "RUN: at line 3"
$ "mkdir" "-p" "C:\src\llvm-project\build.blabla\runtimes\runtimes-bins\compiler-rt\test\profile\Profile-x86_64\Output\gcov-__gcov_flush-terminate.c.tmp.dir"
$ "cd" "C:\src\llvm-project\build.blabla\runtimes\runtimes-bins\compiler-rt\test\profile\Profile-x86_64\Output\gcov-__gcov_flush-terminate.c.tmp.dir"
$ ":" "RUN: at line 4"
$ "C:/src/llvm-project/build.blabla/./bin/clang.exe" "-Wl,-incremental:no" "--coverage" "C:\src\llvm-project\compiler-rt\test\profile\gcov-__gcov_flush-terminate.c" "-o" "C:\src\llvm-project\build.blabla\runtimes\runtimes-bins\compiler-rt\test\profile\Profile-x86_64\Output\gcov-__gcov_flush-terminate.c.tmp"
# command output:
LINK : warning LNK4098: defaultlib 'msvcrt.lib' conflicts with use of other libs; use /NODEFAULTLIB:library
LINK : warning LNK4217: symbol 'malloc' defined in 'libucrt.lib(malloc.obj)' is imported by 'clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj)' in function 'llvm_gcda_start_file'
LINK : warning LNK4217: symbol '_get_osfhandle' defined in 'libucrt.lib(osfinfo.obj)' is imported by 'clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj)' in function 'llvm_gcda_start_file'
LINK : warning LNK4286: symbol '_get_osfhandle' defined in 'libucrt.lib(osfinfo.obj)' is imported by 'clang_rt.profile-x86_64.lib(WindowsMMap.c.obj)'
LINK : warning LNK4217: symbol '__acrt_iob_func' defined in 'libucrt.lib(_file.obj)' is imported by 'clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj)' in function 'llvm_gcda_start_file'
LINK : warning LNK4217: symbol '_errno' defined in 'libucrt.lib(errno.obj)' is imported by 'clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj)' in function 'llvm_gcda_start_file'
LINK : warning LNK4217: symbol '__stdio_common_vfprintf' defined in 'libucrt.lib(output.obj)' is imported by 'clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj)' in function 'fprintf'
LINK : warning LNK4217: symbol 'free' defined in 'libucrt.lib(free.obj)' is imported by 'clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj)' in function 'llvm_gcda_emit_arcs'
LINK : warning LNK4217: symbol 'fflush' defined in 'libucrt.lib(fflush.obj)' is imported by 'clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj)' in function 'llvm_gcda_end_file'
LINK : warning LNK4217: symbol 'fclose' defined in 'libucrt.lib(fclose.obj)' is imported by 'clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj)' in function 'llvm_gcda_end_file'
LINK : warning LNK4217: symbol '_fileno' defined in 'libucrt.lib(fileno.obj)' is imported by 'clang_rt.profile-x86_64.lib(InstrProfilingUtil.c.obj)' in function 'lprofLockFileHandle'
LINK : warning LNK4217: symbol '_open_osfhandle' defined in 'libucrt.lib(osfinfo.obj)' is imported by 'clang_rt.profile-x86_64.lib(InstrProfilingUtil.c.obj)' in function 'lprofOpenFileEx'
LINK : warning LNK4217: symbol 'atoi' defined in 'libucrt.lib(atox.obj)' is imported by 'clang_rt.profile-x86_64.lib(InstrProfilingUtil.c.obj)' in function 'lprofGetPathPrefix'
clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj) : error LNK2019: unresolved external symbol __imp_strdup referenced in function llvm_gcda_start_file
oldnames.lib(strdup.obi) : error LNK2001: unresolved external symbol __imp_strdup
clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj) : error LNK2019: unresolved external symbol __imp_open referenced in function llvm_gcda_start_file
oldnames.lib(open.obi) : error LNK2001: unresolved external symbol __imp_open
clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj) : error LNK2019: unresolved external symbol __imp_fdopen referenced in function llvm_gcda_start_file
oldnames.lib(fdopen.obi) : error LNK2001: unresolved external symbol __imp_fdopen
clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj) : error LNK2019: unresolved external symbol __imp_fseek referenced in function llvm_gcda_start_file
clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj) : error LNK2019: unresolved external symbol __imp_ftell referenced in function llvm_gcda_start_file
clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj) : error LNK2019: unresolved external symbol __imp_realloc referenced in function llvm_gcda_start_file
clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj) : error LNK2019: unresolved external symbol __imp_strerror referenced in function llvm_gcda_start_file
clang_rt.profile-x86_64.lib(GCDAProfiling.c.obj) : error LNK2019: unresolved external symbol __imp_fwrite referenced in function llvm_gcda_end_file
clang_rt.profile-x86_64.lib(InstrProfilingUtil.c.obj) : error LNK2019: unresolved external symbol __imp__mkdir referenced in function __llvm_profile_recursive_mkdir
clang_rt.profile-x86_64.lib(InstrProfilingUtil.c.obj) : error LNK2019: unresolved external symbol __imp__fdopen referenced in function lprofOpenFileEx
oldnames.lib(fdopen.obi) : error LNK2001: unresolved external symbol __imp__fdopen
clang_rt.profile-x86_64.lib(InstrProfilingUtil.c.obj) : error LNK2019: unresolved external symbol __imp_getenv referenced in function lprofGetPathPrefix
oldnames.lib(strdup.obi) : error LNK2001: unresolved external symbol __imp__strdup
oldnames.lib(open.obi) : error LNK2001: unresolved external symbol __imp__open
C:\src\llvm-project\build.blabla\runtimes\runtimes-bins\compiler-rt\test\profile\Profile-x86_64\Output\gcov-__gcov_flush-terminate.c.tmp : fatal error LNK1120: 13 unresolved externals

# command stderr:
clang: error: linker command failed with exit code 1120 (use -v to see invocation)

error: command failed with exit status: 0x460

--
[...]
Failed Tests (47):
  Profile-x86_64 :: Windows/coverage-linkage.cpp
  Profile-x86_64 :: Windows/instrprof-multiprocess.test
  Profile-x86_64 :: coverage-inline.cpp
  Profile-x86_64 :: coverage_comments.cpp
  Profile-x86_64 :: coverage_emptylines.cpp
  Profile-x86_64 :: gcc-flag-compatibility.test
  Profile-x86_64 :: gcov-__gcov_flush-terminate.c
  Profile-x86_64 :: gcov-basic.c
  Profile-x86_64 :: gcov-complex-line.c
  Profile-x86_64 :: gcov-dump-and-remove.c
  Profile-x86_64 :: infinite_loop.c
  Profile-x86_64 :: instrprof-basic.c
  Profile-x86_64 :: instrprof-block-coverage.c
  Profile-x86_64 :: instrprof-bufferio.c
  Profile-x86_64 :: instrprof-dump.c
  Profile-x86_64 :: instrprof-entry-coverage.c
  Profile-x86_64 :: instrprof-error.c
  Profile-x86_64 :: instrprof-gcov-exceptions.test
  Profile-x86_64 :: instrprof-gcov-multiple-bbs-single-line.test
  Profile-x86_64 :: instrprof-gcov-one-line-function.test
  Profile-x86_64 :: instrprof-gcov-switch.test
  Profile-x86_64 :: instrprof-gcov-two-objects.test
  Profile-x86_64 :: instrprof-get-filename.c
  Profile-x86_64 :: instrprof-groups.c
  Profile-x86_64 :: instrprof-override-filename-then-reset-default.c
  Profile-x86_64 :: instrprof-override-filename-with-env.c
  Profile-x86_64 :: instrprof-override-filename.c
  Profile-x86_64 :: instrprof-path.c
  Profile-x86_64 :: instrprof-reset-counters.c
  Profile-x86_64 :: instrprof-set-file-object-merging.c
  Profile-x86_64 :: instrprof-set-file-object.c
  Profile-x86_64 :: instrprof-set-filename-then-reset-default.c
  Profile-x86_64 :: instrprof-set-filename.c
  Profile-x86_64 :: instrprof-timestamp.c
  Profile-x86_64 :: instrprof-tmpdir.c
  Profile-x86_64 :: instrprof-value-prof-2.c
  Profile-x86_64 :: instrprof-value-prof-evict.test
  Profile-x86_64 :: instrprof-value-prof-reset.c
  Profile-x86_64 :: instrprof-value-prof.c
  Profile-x86_64 :: instrprof-value-prof.test
  Profile-x86_64 :: instrprof-version-mismatch.c
  Profile-x86_64 :: instrprof-write-file-atexit-explicitly.c
  Profile-x86_64 :: instrprof-write-file-only.c
  Profile-x86_64 :: instrprof-write-file.c
  Profile-x86_64 :: runtime_infinite.c

[zmodem]

I tried

diff --git a/compiler-rt/CMakeLists.txt b/compiler-rt/CMakeLists.txt
index 8485fe9232d0..9c68e84fd072 100644
--- a/compiler-rt/CMakeLists.txt
+++ b/compiler-rt/CMakeLists.txt
@@ -13,6 +13,8 @@ if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR COMPILER_RT_STANDALONE
 endif()

 set(LLVM_COMMON_CMAKE_UTILS "${CMAKE_CURRENT_SOURCE_DIR}/../cmake")
+include(${LLVM_COMMON_CMAKE_UTILS}/Modules/CMakePolicy.cmake
+  NO_POLICY_SCOPE)

 # Add path for custom compiler-rt modules.
 list(INSERT CMAKE_MODULE_PATH 0
diff --git a/runtimes/CMakeLists.txt b/runtimes/CMakeLists.txt
index be68d6df34c2..e1b2e08ffe09 100644
--- a/runtimes/CMakeLists.txt
+++ b/runtimes/CMakeLists.txt
@@ -4,6 +4,8 @@ project(Runtimes C CXX ASM)

 # Add path for custom and the LLVM build's modules to the CMake module path.
 set(LLVM_COMMON_CMAKE_UTILS "${CMAKE_CURRENT_SOURCE_DIR}/../cmake")
+include(${LLVM_COMMON_CMAKE_UTILS}/Modules/CMakePolicy.cmake
+  NO_POLICY_SCOPE)
 list(INSERT CMAKE_MODULE_PATH 0
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake"
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"

but that didn't help.

Also the below didn't help:

diff --git a/compiler-rt/CMakeLists.txt b/compiler-rt/CMakeLists.txt
index 8485fe9232d0..979efc5dfb09 100644
--- a/compiler-rt/CMakeLists.txt
+++ b/compiler-rt/CMakeLists.txt
@@ -398,9 +398,9 @@ if(MSVC)
       CMAKE_C_FLAGS_MINSIZEREL CMAKE_C_FLAGS_RELWITHDEBINFO
       CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE
       CMAKE_CXX_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_RELWITHDEBINFO)
-      string(REGEX REPLACE "/M[DT]d" "/MT" ${flag_var} "${${flag_var}}")
-      string(REGEX REPLACE "/MD" "/MT" ${flag_var} "${${flag_var}}")
-      string(REGEX REPLACE "/D_DEBUG" "" ${flag_var} "${${flag_var}}")
+      string(REGEX REPLACE "[/-]M[DT]d" "/MT" ${flag_var} "${${flag_var}}")
+      string(REGEX REPLACE "[/-]MD" "/MT" ${flag_var} "${${flag_var}}")
+      string(REGEX REPLACE "[/-]D_DEBUG" "" ${flag_var} "${${flag_var}}")
     endforeach()
   endif()
   append_list_if(COMPILER_RT_HAS_Oy_FLAG /Oy- SANITIZER_COMMON_CFLAGS)

[glandium]

@zmodem CMakePolicy.cmake needs to be included before project(). You need to move the set() and include() right below the cmake_minimum_required.

[zmodem]

Thanks @glandium, that seems to work. With the patch below on top of 7d47dac, I was able to build successfully.

diff --git a/compiler-rt/CMakeLists.txt b/compiler-rt/CMakeLists.txt
index 8485fe9232d0..6489aa17c229 100644
--- a/compiler-rt/CMakeLists.txt
+++ b/compiler-rt/CMakeLists.txt
@@ -5,6 +5,10 @@

 cmake_minimum_required(VERSION 3.20.0)

+set(LLVM_COMMON_CMAKE_UTILS "${CMAKE_CURRENT_SOURCE_DIR}/../cmake")
+include(${LLVM_COMMON_CMAKE_UTILS}/Modules/CMakePolicy.cmake
+  NO_POLICY_SCOPE)
+
 # Check if compiler-rt is built as a standalone project.
 if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR COMPILER_RT_STANDALONE_BUILD)
   project(CompilerRT C CXX ASM)
@@ -12,8 +16,6 @@ if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR COMPILER_RT_STANDALONE
   set_property(GLOBAL PROPERTY USE_FOLDERS ON)
 endif()

-set(LLVM_COMMON_CMAKE_UTILS "${CMAKE_CURRENT_SOURCE_DIR}/../cmake")
-
 # Add path for custom compiler-rt modules.
 list(INSERT CMAKE_MODULE_PATH 0
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake"
diff --git a/runtimes/CMakeLists.txt b/runtimes/CMakeLists.txt
index be68d6df34c2..599529852688 100644
--- a/runtimes/CMakeLists.txt
+++ b/runtimes/CMakeLists.txt
@@ -1,9 +1,13 @@
 # This file handles building LLVM runtime sub-projects.
 cmake_minimum_required(VERSION 3.20.0)
-project(Runtimes C CXX ASM)

 # Add path for custom and the LLVM build's modules to the CMake module path.
 set(LLVM_COMMON_CMAKE_UTILS "${CMAKE_CURRENT_SOURCE_DIR}/../cmake")
+include(${LLVM_COMMON_CMAKE_UTILS}/Modules/CMakePolicy.cmake
+  NO_POLICY_SCOPE)
+
+project(Runtimes C CXX ASM)
+
 list(INSERT CMAKE_MODULE_PATH 0
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake"
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"