Please cherry-pick ab49dce01f211fd80 into llvm-14

[jmorse]

Hi,

Please could ab49dce be cherry-picked into llvm-14. It's NFC, unremarkable, but moderately important to clean up a small pointer-ownership mess that I made around branching time. While it's technically not needed, our lives will be harder if any fixes have to be applied to this part of the compiler at a later date.

[jmorse]

(Put the wrong hash in the title, curses, now fixed)

[llvmbot]

@llvm/issue-subscribers-debuginfo

[tstellar]

/cherry-pick ab49dce

[llvmbot]

/branch llvmbot/llvm-project/issue54130

[llvmbot]

/pull-request llvmbot#112

[tstellar]

@dwblaikie What do you think about backporting this? ab49dce

[dwblaikie]

@tstellar I don't have strong feelings - it seems harmless enough. I'm not sure if this code is more/less likely to need other patches backported to the release branch or later point releases.

LLVM gets these sort of refactorings all the time, so my gut instinct would be that unless this particular code is more likely than average to need backports, I don't see why this particular patch would be worth backporting more than all the other refactoring changes that are made regularly.

@jmorse are there already other patches you expect to backport on top of this? Particular reason this is likely to be more backport-heavy than other areas of the project?