Skip to content

[CIR][CIRGen][Builtin][Neon] Lower neon vcaltd_f64 #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

[CIR][CIRGen][Builtin][Neon] Lower neon vcaltd_f64 #1505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clang/lib/CIR/CodeGen/CIRGenBuiltinAArch64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2713,7 +2713,8 @@ static mlir::Value emitCommonNeonSISDBuiltinExpr(
return emitNeonCall(builder, {argTy}, ops, "aarch64.neon.facge", resultTy,
loc);
case NEON::BI__builtin_neon_vcaltd_f64:
llvm_unreachable(" neon_vcaltd_f64 NYI ");
return emitNeonCall(builder, {argTy}, ops, "aarch64.neon.facgt", resultTy,
loc);
case NEON::BI__builtin_neon_vcalts_f32:
llvm_unreachable(" neon_vcalts_f32 NYI ");
case NEON::BI__builtin_neon_vcvtad_s64_f64:
Expand Down
16 changes: 10 additions & 6 deletions clang/test/CIR/CodeGen/AArch64/neon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15185,12 +15185,16 @@ uint64_t test_vcaled_f64(float64_t a, float64_t b) {
// return (uint32_t)vcalts_f32(a, b);
// }

// NYI-LABEL: @test_vcaltd_f64(
// NYI: [[VCALTD_F64_I:%.*]] = call i64 @llvm.aarch64.neon.facgt.i64.f64(double %b, double %a)
// NYI: ret i64 [[VCALTD_F64_I]]
// uint64_t test_vcaltd_f64(float64_t a, float64_t b) {
// return (uint64_t)vcaltd_f64(a, b);
// }
uint64_t test_vcaltd_f64(float64_t a, float64_t b) {
return (uint64_t)vcaltd_f64(a, b);

// CIR-LABEL: vcaltd_f64
// CIR: [[TMP0:%.*]] = cir.llvm.intrinsic "aarch64.neon.facgt" {{.*}}, {{.*}} : (!cir.double, !cir.double) -> !u64i

// LLVM-LABEL: @test_vcaltd_f64(
// LLVM: [[VCALTD_F64_I:%.*]] = call i64 @llvm.aarch64.neon.facgt.i64.f64(double %0, double %1)
// LLVM: ret i64 [[VCALTD_F64_I]]
}

int64_t test_vshrd_n_s64(int64_t a) {
return (int64_t)vshrd_n_s64(a, 1);
Expand Down
Loading