-
Notifications
You must be signed in to change notification settings - Fork 175
[CIR][CIRGen][Builtin][Neon] Lower neon_vset_lane_f64 #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on it. Just a typo.
c9b0bb7
to
718ae57
Compare
Thanks, still needs some conflict resolution and I'll merge it. |
Thank you, I found a typo (test_vsetq_land_f64 -> test_vsetq_lane_f64) in the previous PR too, I will fix It and resolve the conflict clangir/clang/test/CIR/CodeGen/AArch64/neon-misc.c Lines 140 to 151 in 3eeb6b4
|
718ae57
to
04f93ed
Compare
@bcardosolopes There is one CI job that failed, i think it's unrelated to the diff |
Lowering Neon `vset_lane_f64` References: [Clang CGBuiltin Implementation](https://github.com/llvm/clangir/blob/2b1a638ea07ca10c5727ea835bfbe17b881175cc/clang/lib/CodeGen/CGBuiltin.cpp#L12342) [Builtin definition](https://developer.arm.com/architectures/instruction-sets/intrinsics/vset_lane_f64)
Lowering Neon `vset_lane_f64` References: [Clang CGBuiltin Implementation](https://github.com/llvm/clangir/blob/2b1a638ea07ca10c5727ea835bfbe17b881175cc/clang/lib/CodeGen/CGBuiltin.cpp#L12342) [Builtin definition](https://developer.arm.com/architectures/instruction-sets/intrinsics/vset_lane_f64)
Lowering Neon
vset_lane_f64
References:
Clang CGBuiltin Implementation
Builtin definition