[CIR][CIRGen][Builtin][Neon] Lower neon_vqdmlal, neon_vqdmlsl #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
Nov 11, 2024
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Since you took the opportunity to clean up whitespaces in the other PR, why didn't it fix all of it? A bit odd to see even more in this one - since they are all unrelated to the changes anyways.
Member
|
Please make this PR only do relevant changes, explanations on how to proceed with NFC changes already given recently. |
Contributor
Author
will revert unrelated formatting changes as I probably accidentally formatted the whole file. Will have another NFC PR to address this problem. |
bcardosolopes
approved these changes
Nov 13, 2024
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.