Disable Certbot's built in log rotation #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bot, here is the pushed image/manifest for this PR:
|
1 task
thespad
approved these changes
May 8, 2025
github-project-automation
bot
moved this from PRs Ready For Team Review
to PRs Approved
in Issue & PR Tracker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
https://eff-certbot.readthedocs.io/en/stable/using.html#log-rotation
https://eff-certbot.readthedocs.io/en/stable/using.html#certbot-command-line-options
https://github.com/certbot/certbot/blob/62361dac442c065005455a0c78ea066fedc6c5f8/certbot/src/certbot/_internal/log.py#L172
Certbot's new log rotate functionality performs a rotation on every run of the
certbotcommand. Our init runs the command at least one time (up to 4 times depending on conditional logic), and thencronruns daily. I investigated using their built-in log rotate, but it is less ideal to keep logs over time if a container is frequently restarted or updated because this reduces the time period for logs that would be kept by certbot's built in log rotation.