ynl-gen-cpp: add support for generating rt-link #8
+7,007
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better format for C++ lambda: a space between return type and function body. Signed-off-by: Zibo Gong <[email protected]>
rt- family can contain - in its family name. It should be correct to use c_name. Signed-off-by: Zibo Gong <[email protected]>
The patch fixes an issue in the determination of type_consistent. It used to set type_consistent to be False when dump exists but do does not exist. This is inaccurate and will lead to exceptions. This case should be treated as consistent but one-sided. Signed-off-by: Zibo Gong <[email protected]>
op attribute lists are referenced without checking if they are present. Attibute list can be a optional property so this patch add them initially if missing. Signed-off-by: Zibo Gong <[email protected]>
rt-link spec has multi binary attribute with struct. This patch adds support for that. Signed-off-by: Zibo Gong <[email protected]>
zb-gong
force-pushed
the
rt_family
branch
5 times, most recently
from
6a5134b to
d44dc67
Compare
|
Hi Zibo! Sorry I completely missed this PR! |
IPv6 are expressed as binary with exact len. This patch adds support for that. Also, the patch re-generate the source files due to an additional header. Signed-off-by: Zibo Gong <[email protected]>
rt-link operation can have its fixed header, which may not be the same as the the family one. Signed-off-by: Zibo Gong <[email protected]>
The notification op should use crud-style op when it is classic netlink-raw family. Signed-off-by: Zibo Gong <[email protected]>
The patch adds header specified in attribute-set. Signed-off-by: Zibo Gong <[email protected]>
A operation can have multiple values with random order. The value of max_num in array should use the max value after traversing the ops. Signed-off-by: Zibo Gong <[email protected]>
Prepare for construting Struct that represent sub messages. Signed-off-by: Zibo Gong <[email protected]>
This patch enables generation for rt-link and adds a simple application test in samples/. Signed-off-by: Zibo Gong <[email protected]>
|
Ah I forgot to regenerate the source files due to a previous change. Could you try it again? |
|
Looks good now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code generation support for rt-link, with most of the logic ported from ynl_gen_c.py. The main feature introduced is sub-message handling, along with fixes for several minor formatting issues.