refactor(app/integration): clean up Server constructors
#3693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
approved these changes
Mar 3, 2025
cratelyn
force-pushed
the
kate/app-integration-request-response-aliases
branch
from
7673273 to
349d188
Compare
Base automatically changed from
kate/app-integration-request-response-aliases
to
main
March 3, 2025 23:46
this commit removes some misdirection from the various constructors for our test server. currently, we expose a family of constructor functions `server::new()`, `server::http1()`, ..., and so forth. each of these invoke a private `server::Server::http1()`, `server::Server::http2()`, `server::Server::http2_tls()`, ..., counterpart, which then delegates down once more to another private constructor `server::Server::new()`. this is all a bit roundabout, particularly because these private constructors are not used by any other internal code in the `server` submodule. this commit removes these inherent `Server` constructors, since they are private and not used by any test code. each free-standing constructor function is altered to instead directly construct a `Server`. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/app-integration-server-constructors
branch
from
26772e0 to
bb39c31
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit removes some misdirection from the various constructors for our test server.
currently, we expose a family of constructor functions
server::new(),server::http1(), ..., and so forth.each of these invoke a private
server::Server::http1(),server::Server::http2(),server::Server::http2_tls(), ..., counterpart, which then delegates down once more to another private constructorserver::Server::new().this is all a bit roundabout, particularly because these private constructors are not used by any other internal code in the
serversubmodule.this commit removes these inherent
Serverconstructors, since they are private and not used by any test code. each free-standing constructor function is altered to instead directly construct aServer.NB: based upon #3692.