Skip to content

Change guard let strongSelf to guard let self #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change guard let strongSelf to guard let self #26

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1d5d63
Change `guard let strongSelf` to `guard let self`
samwarfield Jan 28, 2019
d5c68f3
Update README.md
samwarfield Jan 28, 2019
b388a76
Merge pull request #1 from samwarfield/samwarfield-patch-strongSelf
samwarfield Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,13 +403,16 @@ let lastName = name.lastName
* **3.1.6** Be careful when calling `self` directly from an escaping closure as this can cause a retain cycle - use a [capture list](https://developer.apple.com/library/ios/documentation/swift/conceptual/Swift_Programming_Language/Closures.html#//apple_ref/doc/uid/TP40014097-CH11-XID_163) when this might be the case:

```swift
myFunctionWithEscapingClosure() { [weak self] (error) -> Void in
// you can do this

self?.doSomething()

// or you can do this
myFunctionWithEscapingClosure() { [weak self] in
// PREFERRED
guard let self = self else {
debugPrint("What happened? You lost self...")
return
}

self.doSomething()

// NOT PREFERRED
guard let strongSelf = self else {
return
}
Expand Down