Skip to content

Conversation

@asbjornu
Copy link
Member

@asbjornu asbjornu commented Nov 5, 2018

This PR adds a Travis CI build, code coverage via Codecov and fixes redirect issues that caused 3 tests to fail.

@goofballLogic
Copy link
Member

Looks like this is targeting DotNet core (which is wonderful). Does it still support (and build) the .net Framework version(s)?

@asbjornu
Copy link
Member Author

@goofballLogic: .NET Core support was added in #37. As TargetFrameworks is set to netstandard1.3, netstandard2.0 and netcoreapp2.1, framework should be supported still. I haven't tested, though.

Copy link
Member

@goofballLogic goofballLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in favour of your opinion over mine.

@asbjornu
Copy link
Member Author

@goofballLogic: Thanks. The redirect check is basically a minimal effort to get the tests to succeed. I agree a less naïve approach should be implemented, but as the primary focus of this PR is to set up continuous integration, automatic testing and code coverage, I feel it's a bit out of scope for what I'm trying to achieve here. That does not mean we shouldn't continue to improve on the code, however. It will only be much easier to do so once this PR is merged since all future pull requests will then be automatically tested by Travis. 😃

@asbjornu asbjornu merged commit 5d49e51 into master Jan 10, 2019
@asbjornu asbjornu deleted the feature/travis branch January 10, 2019 23:07
@goofballLogic
Copy link
Member

goofballLogic commented Jan 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants