Skip to content

Conversation

@xStrom
Copy link
Member

@xStrom xStrom commented Jul 1, 2022

@xStrom xStrom added maintenance cleans up code or docs S-needs-review waits for review labels Jul 1, 2022
@xStrom
Copy link
Member Author

xStrom commented Jul 1, 2022

Looks like some pseudocode in GTK backend comments is failing, will need to look into that a bit more.

@jneem
Copy link
Member

jneem commented Jul 1, 2022

Those doc comments have been there since forever. Strange that rustdoc only just decided to try compiling them...

@xStrom
Copy link
Member Author

xStrom commented Jul 1, 2022

I don't know for sure, but this line in the changelog might explain it:

cargo test now passes --target to rustdoc if the specified target is the same as the host target. #10594

@xStrom
Copy link
Member Author

xStrom commented Jul 1, 2022

The tests require the code to be full, even if most of it is hidden. Given that it is only one macro's docs, I'll just set the ignore tag for it.

@xStrom xStrom removed the S-needs-review waits for review label Jul 1, 2022
@xStrom xStrom merged commit 7a87f4d into linebender:master Jul 1, 2022
@xStrom xStrom deleted the clippy-162 branch July 1, 2022 20:55
xarvic pushed a commit to xarvic/druid that referenced this pull request Jul 29, 2022
xarvic pushed a commit to xarvic/druid that referenced this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance cleans up code or docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants