Skip to content

Conversation

@onevcat
Copy link
Member

@onevcat onevcat commented Oct 7, 2025

Summary

  • ensure LoginManager.reset() cancels the active process on the main actor and clarify token retention in docs
  • add regression coverage that verifies reset/setup flows reuse keychain tokens only when returning to the same channel
  • extend the sample app with persisted channel id switching and in-app reset/setup controls

This should provide a quick and temporary solution to #211

- Add testResetLoginManager to verify basic reset behavior
- Add testResetLoginManagerWithActiveProcess to test reset during active login
- Ensure proper cleanup of shared instances and SDK state
- Verify reset error handling for ongoing processes
- Add detailed documentation for LoginManager.reset() method with usage examples
- Document cleanCurrentProcess() and configureSDK() private methods
- Add documentation for loginManagerReset error case
- Fix minor formatting in processDiscarded error documentation
@onevcat onevcat requested a review from daviscdev October 7, 2025 06:45
Copy link

@daviscdev daviscdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you!

@onevcat onevcat merged commit e935cf1 into master Oct 29, 2025
23 of 25 checks passed
@onevcat onevcat deleted the fix/remove-multiple-channel-assertion branch October 29, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants