Add option to run sshfs with idmap argument #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes it possible to have user ID remapped between local and remote. Signed-off-by: Marek Pikuła <[email protected]>
MarekPikula
force-pushed
the
feature/sshfs-idmap-support
branch
from
bd19247 to
9941807
Compare
AkihiroSuda
reviewed
May 23, 2022
| Name: "sshfs-idmap", | ||
| Usage: "set sshfs idmap option", | ||
| Value: "none", | ||
| }, |
There was a problem hiding this comment.
I'm feeling we should rather add generic -o to support arbitrary mount options.
Addition of sshfs-nonempty was design mistake and should be deprecated in favor of -o nonempty
|
Let me close this in favor of #51 Thanks anyway for your contribution. |
|
Sure thing, I had a lot on my plate recently and didn't really get down to learning Go enough to make the change myself 😜 It's nice that it got merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes it possible to have user ID remapped between local and remote.