Skip to content

Check for infinity, it creates trouble #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Check for infinity, it creates trouble #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions varopt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type Varopt struct {
// passed in separately.
type Sample interface{}

var ErrInvalidWeight = fmt.Errorf("Negative, zero, or NaN weight")
var ErrInvalidWeight = fmt.Errorf("Negative, Zero, Inf or NaN weight")

// New returns a new Varopt sampler with given capacity (i.e.,
// reservoir size) and random number generator.
Expand Down Expand Up @@ -78,7 +78,7 @@ func (s *Varopt) Add(sample Sample, weight float64) (Sample, error) {
Weight: weight,
}

if weight <= 0 || math.IsNaN(weight) {
if weight <= 0 || math.IsNaN(weight) || math.IsInf(weight, 1) {
return nil, ErrInvalidWeight
}

Expand Down