Skip to content

lnwire: switch chan_type feature to bits 44/45 #5874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2021
Merged

lnwire: switch chan_type feature to bits 44/45 #5874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
028fc86
lnwire: switch chan_type feature to bits 44/45
Roasbeef Oct 20, 2021
2878714
docs/release-notes: add section for propr chan type feature bit
Roasbeef Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/release-notes/release-notes-0.14.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ need to be kept in memory.
initiator to signal their desired channel type to use with the remote peer. If
the remote peer supports said channel type and agrees, the previous implicit
negotiation based on the shared set of feature bits is bypassed, and the
proposed channel type is used.
proposed channel type is used. [Feature bits 44/45 are used to
signal](https://github.com/lightningnetwork/lnd/pull/5874) this new feature.


## RPC Server

Expand Down
8 changes: 2 additions & 6 deletions lnwire/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,19 +145,15 @@ const (
// negotiation methods. With this bit, there is no longer a "default"
// implicit channel commitment type, allowing a connection to
// open/maintain types of several channels over its lifetime.
//
// TODO: Decide on actual feature bit value.
ExplicitChannelTypeRequired = 2020
ExplicitChannelTypeRequired = 44

// ExplicitChannelTypeOptional is an optional bit that denotes that a
// connection established with this node is to use explicit channel
// commitment types for negotiation instead of the existing implicit
// negotiation methods. With this bit, there is no longer a "default"
// implicit channel commitment type, allowing a connection to
// open/maintain types of several channels over its lifetime.
//
// TODO: Decide on actual feature bit value.
ExplicitChannelTypeOptional = 2021
ExplicitChannelTypeOptional = 45

// maxAllowedSize is a maximum allowed size of feature vector.
//
Expand Down