refactor: use a more modern writing style to simplify code

[joemicky]

Optimize code using a more modern writing style. Official support from Go, for more details visit https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize.

Seem as lightninglabs/aperture#188

[gemini-code-assist]

Summary of Changes

Hello @joemicky, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors existing Go code to align with more modern Go writing styles and best practices, as recommended by tools like "gopls/internal/analysis/modernize". The changes primarily focus on simplifying loop variable declarations, optimizing numerical comparisons, and updating string/byte slice manipulations for improved readability and conciseness.

Highlights

• Loop Variable Simplification: Eliminated redundant variable re-declarations within "for...range" loops across multiple files, leveraging Go's modern loop semantics.
• Numerical Calculation Optimization: Replaced verbose "if" conditions with the more concise "max()" function for determining maximum values in amount and fee calculations.
• String and Byte Slice Formatting: Updated "caveatPrefix" initialization to use "fmt.Appendf" for more efficient and idiomatic byte slice formatting.
• Map Copying Modernization: Introduced the "maps.Copy" function for a cleaner and more direct way to copy map contents.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a series of refactorings to modernize the Go codebase, aligning it with current best practices and language features. The changes include removing redundant variable shadowing in loops, which is no longer necessary since Go 1.22, and replacing conditional logic with the max() built-in function where applicable. Additionally, the code now leverages fmt.Appendf and maps.Copy for improved performance and readability. All changes are correct and represent a positive improvement to the codebase's quality and maintainability. I have no further suggestions.

[lightninglabs-deploy]

@joemicky, remember to re-request review from reviewers when ready