Re-add accidentally removed handle_channel_update call
#4065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In e620310, we made many, many small changes to prepare for running `rustfmt` on `peer_handler.rs`. Unfortunately, in the process we seem to have introduced a bug where we'd only call `handle_channel_update` on the `RoutingMessageHandler`, but not the `ChannelMessageHandler` anymore. Here, we fix this and reinstate proper working of our channel updates.
|
👋 Thanks for assigning @joostjager as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4065 +/- ##
==========================================
- Coverage 88.76% 88.75% -0.01%
==========================================
Files 176 176
Lines 129518 129520 +2
Branches 129518 129520 +2
==========================================
- Hits 114968 114960 -8
- Misses 11945 11954 +9
- Partials 2605 2606 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In e620310, we made many, many small changes to prepare for running
rustfmtonpeer_handler.rs. Unfortunately, in the process we seem to have introduced a bug where we'd only callhandle_channel_updateon theRoutingMessageHandler, but not theChannelMessageHandleranymore.Here, we fix this and reinstate proper working of our channel updates.