Post-#3897 fixes and cleanups #4022
Merged
+120
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the changes to `fuzz/src/full_stack.rs` in commit 61bc1e0 which were spuriously included after a rebase and ultimately broke the fuzzing test.
We actually store the latest counterparty revoked commitment transaction number in two places in `Channel` - as `context.cur_counterparty_commitment_transaction_number + 2` and in `commitment_secrets`. Here we add a debug assertion that both values are equal.
This cleans up `test_peer_storage` a bit to clarify what messages are actually being exchanged.
In general we shouldn't be adding new tests in `channelmanager.rs`
...somewhat cleaning up rustfmt crust.
|
👋 Thanks for assigning @jkczyz as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4022 +/- ##
==========================================
- Coverage 88.82% 88.76% -0.06%
==========================================
Files 175 175
Lines 127767 127753 -14
Branches 127767 127753 -14
==========================================
- Hits 113486 113404 -82
- Misses 11712 11784 +72
+ Partials 2569 2565 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnull
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.