Fix panic when calling batch_funding_transaction_generated early
#4015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TheBlueMatt
commented
Aug 16, 2025
TheBlueMatt
commented
|
👋 I see @joostjager was un-assigned. |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
`functional_tests.rs` is a rather large beast, but with this move we take it down to under 10k LoC.
If a user calls `batch_funding_transaction_generated` before a channel is ready to fund its possible to hit an `unwrap` when the transaction-scanning logic attempts to fetch the channel's expected output `scriptPubKey`. While users shouldn't be doing this, we should also avoid the panic, so here check the channel state first. Found by the `full_stack_target` fuzzer.
When a channel gets replaced before we can fund it, its possible now (due to RNG output repetition) to hit the "trying to fund channel before its ready to be funded" error in the `full_stack_target` fuzzer. Thus, we now simply ignore errors when funding.
TheBlueMatt
force-pushed
the
2025-08-fst-funding
branch
from
c20d733 to
c1fefcf
Compare
|
Rebased. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4015 +/- ##
=======================================
Coverage 88.84% 88.84%
=======================================
Files 175 175
Lines 127723 127762 +39
Branches 127723 127762 +39
=======================================
+ Hits 113472 113516 +44
+ Misses 11686 11679 -7
- Partials 2565 2567 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.