Skip to content

Only write BlindedHopFeatures if any features are set #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2024
Merged

Only write BlindedHopFeatures if any features are set #2949

merged 1 commit into from
Mar 20, 2024

Conversation

valentinewallace
Copy link
Contributor

Minor space-saving optimization. Follow-up to #2945.

@valentinewallace valentinewallace mentioned this pull request Mar 19, 2024
Merged
TheBlueMatt
TheBlueMatt approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I assume we've got pretty reasonable test coverage for this given its now the always-taken path, so will go ahead and merge this.

@TheBlueMatt TheBlueMatt merged commit 5c49358 into lightningdevkit:main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinewallace @TheBlueMatt