bolt 11: add test vector for p2tr fallback address #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
t-bast
approved these changes
Aug 12, 2025
Collaborator
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
ACK f8a4f93, I verified that this works in eclair out of the box.
Even though we've said in yesterday's spec meeting that we probably want to deprecate the fallback address from lightning invoices, in favor of using BIP21 or BIP353 instead to provide on-chain fallbacks separately from off-chain payment information.
t-bast
added a commit
to ACINQ/eclair
that referenced
this pull request
Aug 12, 2025
Add test vectors from lightning/bolts#1276 and lightning/bolts#1264
thomash-acinq
pushed a commit
to ACINQ/eclair
that referenced
this pull request
Aug 18, 2025
Add test vectors from lightning/bolts#1276 and lightning/bolts#1264
27 tasks
Contributor
|
ACK |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test vector for invoices with a Pay to Taproot (P2TR) fallback address in BOLT 11.