Fix undefined shader texture bind #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Wouter lucas van Boesschoten <[email protected]>
wouterlucas
added a commit
that referenced
this pull request
Jun 26, 2025
If we made really quick changes to an image node (e.g. alpha 0 to 1 back 0) you could end up with race conditions that caused a duplicate cleanup of the texture. Resulting in the issues seen (and guarded) with #597 This change addresses the root cause by avoiding duplicate `load` of textures and cleaning up textures that are in an transitional state (`fetching` / `fetched` / `loading` etc). This avoids a race condition where the memory manager tries to cleanup a texture that is still `loading` or similar, which is especially prevalent on CPU starved devices with heavy transitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.