fix: deprecate CoreNode.preventCleanup and re-introduce preload option #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikhaandrikman
approved these changes
Jan 14, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
Flag was deprecated in #486 and released in 2.9.0 with a warning/messaging. This is moved to texture Options for better clarity. This PR will drop it entirely from 3.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
textureOptions.preloadwas removed during the Texture Throttling refactor, reintroduced it even though its loading will be throttled.While looking at the properties, decided to move
preventCleanuptotextureOptionsinstead of as a property on theCoreNode. Technically this controls the behaviour of the texture, not the core node. Hence it better belongs ontextureOptions.Will throw a deprecation warning in dev mode for a couple of releases and then we'll drop it.