Skip to content

fix: prevent cleanup of SDF Font Face textures for now #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: prevent cleanup of SDF Font Face textures for now #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/core/text-rendering/font-face-types/SdfTrFontFace/SdfTrFontFace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,14 @@ export class SdfTrFontFace<
// Load the texture
stage.txManager.loadTexture(this.texture, true);

this.texture.once('loaded', () => {
// FIXME This is a stop-gap solution to avoid Font Face textures to be cleaned up
// Ideally we do want to clean up the textures if they're not being used to save as much memory as possible
// However, we need to make sure that the font face is reloaded if the texture is cleaned up and needed again
// and make sure the SdfFontRenderer is properly guarded against textures being reloaded
// for now this will do the trick and the increase on memory is not that big
this.texture.preventCleanup = true;

this.texture.on('loaded', () => {
this.checkLoaded();
// Make sure we mark the stage for a re-render (in case the font's texture was freed and reloaded)
stage.requestRender();
Expand Down
Loading